Skip to content

Improve sidebar styling #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirhhashemi wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −23
Open

Improve sidebar styling #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42467df
Improve sidebar styling
amirhhashemi Jul 27, 2026
9f8afd2
Merge branch 'main' into improve-sidebar
kodiakhq[bot] Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osmium/src/ui/layout/main-navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function MainNavigation(_props: MainNavigationProps) {
});

return (
<nav class="custom-scrollbar h-full overflow-y-auto pb-20 md:h-[calc(100vh-7rem)]">
<nav class="custom-scrollbar h-full scrollbar-gutter-stable overflow-y-auto pr-4 pb-20 md:h-[calc(100vh-7rem)]">
<VersionSelector />
<Tabs value={selectedTab()}>
<Tabs.List class="sticky top-0 z-10 grid w-full grid-cols-2 md:bg-slate-50 md:dark:bg-slate-900">
Expand All @@ -140,7 +140,7 @@ export function MainNavigation(_props: MainNavigationProps) {
>
Reference
</Tabs.Trigger>
<Tabs.Indicator class="absolute bottom-0 h-0.5 bg-blue-500 transition-all duration-250 dark:bg-blue-500" />
<Tabs.Indicator class="absolute bottom-0 h-0.5 bg-blue-500 transition-all duration-250" />
</Tabs.List>
<Tabs.Content value="learn" class="relative mt-5 w-full">
<Show
Expand Down
40 changes: 19 additions & 21 deletions osmium/src/ui/layout/version-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,28 +38,26 @@ export default function VersionSelector() {
sameWidth
placement="bottom-start"
>
<div class="mx-1">
<Popover.Trigger
class="flex h-10 w-full items-center justify-between rounded-lg text-left shadow-md ring-1 shadow-black/5 ring-black/90 ring-inset dark:ring-white/10"
aria-label="Change version"
disabled={options().length <= 1}
>
<span class="prose prose-slate flex items-center truncate pl-2 text-lg text-slate-700 dark:text-slate-300">
<Icon
class="mr-2 w-5 fill-slate-700 pl-1 dark:fill-slate-200"
path={tag}
/>
{getOptionLabel(current())}
</span>
<Popover.Trigger
class="flex h-10 w-full items-center justify-between rounded-lg text-left shadow-md ring-1 shadow-black/5 ring-black/90 ring-inset dark:ring-white/10"
aria-label="Change version"
disabled={options().length <= 1}
>
<span class="prose prose-slate flex items-center truncate pl-2 text-lg text-slate-700 dark:text-slate-300">
<Icon
class="mr-2 w-5 fill-slate-700 pl-1 dark:fill-slate-200"
path={tag}
/>
{getOptionLabel(current())}
</span>

<Show when={options().length > 1}>
<Icon
class="mr-2 w-6 fill-slate-700 pl-1 dark:fill-slate-200"
path={chevronUpDown}
/>
</Show>
</Popover.Trigger>
</div>
<Show when={options().length > 1}>
<Icon
class="mr-2 w-6 fill-slate-700 pl-1 dark:fill-slate-200"
path={chevronUpDown}
/>
</Show>
</Popover.Trigger>
<Popover.Portal>
<Popover.Content class="z-50 space-y-1 rounded-xl bg-white p-2 text-sm shadow-md ring-1 shadow-black/5 ring-black/5 dark:bg-slate-800 dark:ring-white/5">
<For each={options()}>
Expand Down
Loading