Skip to content

refactor: migrate avoid_unused_parameters#290

Open
andrew-bekhiet-solid wants to merge 2 commits into
analysis_server_migrationfrom
248-migrate-avoid_unused_parameters
Open

refactor: migrate avoid_unused_parameters#290
andrew-bekhiet-solid wants to merge 2 commits into
analysis_server_migrationfrom
248-migrate-avoid_unused_parameters

Conversation

@andrew-bekhiet-solid

Copy link
Copy Markdown
Collaborator

removes LintCodeCopyWith so the tests can compile, can be re-added later
improves code comments
adds FakeAnalysisOptionsLoader to help in testing

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the avoid_unused_parameters lint rule to align with the new SolidLintRule API, replacing custom lint builder APIs with RuleVisitorRegistry and RuleContext. It also introduces comprehensive unit tests and a fake analysis options loader for testing. Feedback on the changes highlights a potential issue in visitFunctionExpression where anonymous functions defined inside excluded methods or constructors are not correctly ignored, which could lead to false positives. A suggestion was provided to check for any enclosing executable declaration to resolve this.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@andrew-bekhiet-solid andrew-bekhiet-solid linked an issue Jun 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate avoid_unused_parameters

2 participants