Skip to content

Update example build files#98

Open
andrew-bekhiet-solid wants to merge 4 commits into
mainfrom
update-example-build-files
Open

Update example build files#98
andrew-bekhiet-solid wants to merge 4 commits into
mainfrom
update-example-build-files

Conversation

@andrew-bekhiet-solid

Copy link
Copy Markdown
Collaborator

Also adds missing internet access permissions to macos and android

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android, iOS, macOS, and Web configurations for the Flutter example app, upgrading Gradle, Kotlin, Java, and platform deployment targets. However, several critical issues were identified in the changes: the specified Gradle version (8.14) and plugin versions (Android Gradle Plugin 8.11.1, Kotlin 2.2.20) do not exist and will cause build failures. Additionally, the iOS AppDelegate uses non-standard Flutter APIs (FlutterImplicitEngineDelegate and FlutterImplicitEngineBridge) that will result in compilation errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread example/android/gradle/wrapper/gradle-wrapper.properties
Comment thread example/android/settings.gradle
Comment thread example/ios/Runner/AppDelegate.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant