collections: write wincode vec elements via schema to match reader#197
Open
plutohan wants to merge 1 commit into
Open
collections: write wincode vec elements via schema to match reader#197plutohan wants to merge 1 commit into
plutohan wants to merge 1 commit into
Conversation
Contributor
|
@febo can you take a look? |
Contributor
|
Thanks for the PR @plutohan! I left a comment on the issue since supporting non-pod types might affect how JS handles these types. Let's wait to see what @lorisleiva says about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196.
The wincode
SchemaWriteimpls forTrailingVecand the prefixed-vec wrappers wrote elements as a raw byte copy sized bysize_of::<T>(), while the read side decodes each element via its schema. For non-PODTthose sizes disagree and the parse boundary drifts, so the field after the vector decodes wrong.Both impls now write and size each element through
SchemaWrite, matching the reader. No wire-format change for POD types. Added non-POD round-trip regression tests with a trailing field to pin the parse boundary.