feat(basics): migrate 5 pilot programs from ts-mocha to tsx + node:test runner by NikkiAung · Pull Request #636 · solana-foundation/program-examples

NikkiAung · 2026-07-21T05:30:54Z

Summary

All basics/ native/pinocchio/asm test files already import describe/test from node:test, yet they're launched through ts-mocha which contributes nothing — node:test self-registers and auto-runs at process exit. This PR removes the dead mocha launcher and standardises the 5 pilot programs on:

Runner: tsx --test <file> (matches pattern already in use at games/world-cup/pinocchio)
Assertions: node:assert (drop chai)
Types: @types/node only (drop @types/mocha, @types/chai)

Pilot programs (5) — chosen to cover all variants

Program	CI workflow	Runtime	Assertion change
`basics/hello-solana/native`	native	solana-bankrun	`chai` → `node:assert`
`basics/counter/native`	native	solana-bankrun	`chai` → `node:assert`
`basics/account-data/pinocchio`	pinocchio	litesvm	none (bare throw)
`basics/checking-accounts/asm`	asm	solana-bankrun	none (already `node:assert`)
`basics/create-account/native`	native	solana-bankrun	none (no assertions)

Changes per program

package.json — test script: pnpm ts-mocha -p ... -t 1000000 <file> → tsx --test <file>; drop mocha/ts-mocha/@types/mocha/chai/@types/chai; add tsx ^4.22.0 + @types/node ^22.19.1
tsconfig.json — types: ["mocha","chai"(,"node")] → ["node"]
hello-solana/native + counter/native test files — import { assert } from "chai" → import assert from "node:assert" (identical truthy semantics; no call-site edits)
pnpm-lock.yaml — regenerated per package (mocha/chai tree removed, tsx added)

No CI workflow changes needed — tests are invoked via the pnpm test script that build-and-test already chains into.

Test plan

CI solana-native.yml passes for hello-solana/native, counter/native, create-account/native
CI solana-pinocchio.yml passes for account-data/pinocchio
CI solana-asm.yml passes for checking-accounts/asm
Grep: no residual ts-mocha, "mocha", or from "chai" in the 5 programs
Follow-up PR to migrate remaining ~29 basics programs once this pilot is green

greptile-apps · 2026-07-21T05:32:51Z

Greptile Summary

This PR migrates five basics/ pilot projects to Node’s test runner. The main changes are:

Replaces ts-mocha with tsx --test.
Replaces Chai assertions with node:assert where needed.
Removes Mocha and Chai dependencies and types.
Regenerates each pilot project’s lockfile.

Confidence Score: 5/5

This looks safe to merge.

The five package manifests match their regenerated lockfile importers.
The assertion imports support the existing truthiness checks.
No blocking issue remains from the latest fixes.

Important Files Changed

Filename	Overview
basics/account-data/pinocchio/package.json	Migrates the test runner and dependencies, with matching lockfile entries.
basics/checking-accounts/asm/package.json	Migrates the test runner and removes unused Mocha dependencies.
basics/counter/native/package.json	Migrates the test runner and keeps package metadata aligned with the lockfile.
basics/create-account/native/package.json	Migrates the test runner and updates the local development dependencies.
basics/hello-solana/native/package.json	Migrates the test runner and removes the Chai and Mocha dependency tree.
basics/counter/native/tests/counter.test.ts	Replaces the Chai assertion import with the compatible Node assertion API.
basics/hello-solana/native/tests/index.test.ts	Replaces the Chai assertion import with the compatible Node assertion API.

_{Reviews (7): Last reviewed commit: "fix(#636): remove stale mocha/chai type ..." | Re-trigger Greptile}

greptile-apps · 2026-07-21T05:32:55Z

    "solana-bankrun": "^0.3.0",
    "ts-mocha": "^10.0.0",
-    "typescript": "^4.3.5"
+    "typescript": "^5.5.0"


Frozen Lockfiles No Longer Match

This TypeScript range change is mirrored across many non-pilot projects without updating their local lockfiles. The CI matrices run pnpm install --frozen-lockfile inside each project, so these jobs reject the stale importer before building or testing; either revert the unrelated upgrades or regenerate every affected lockfile.

Why is there a typescript change as well? seems like the lock files aren't generated even tho the typescript version changed

This file — basics/account-data/native — is not one of the 5 pilot programs. The pilot for account-data is basics/account-data/pinocchio. So this TypeScript bump (^4.3.5 → ^5.5.0) appears to be a stray/unintended change that leaked into the PR.

Because no other modifications were made to this package (still using ts-mocha, chai, etc.) and the corresponding pnpm-lock.yaml for this directory wasn't regenerated, pnpm install --frozen-lockfile in CI will reject it — the lockfile's resolved TypeScript entry still reflects the old range.

The fix is simply to revert this change:

Suggested change

"typescript": "^5.5.0"

"typescript": "^4.3.5"

If you do intend to bump TypeScript across non-pilot packages as a separate concern, that should be its own PR with all affected lockfiles regenerated.

Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.

Addressed in 5e26fde — basics/account-data/native/package.json and all 33 other non-pilot files have been reverted to main. The PR now only touches the 5 pilot programs.

Reverted in 5e26fde — that file is back to main state and no longer part of this PR. The TypeScript bump for non-pilot packages belongs in PR #633.

dev-jodee · 2026-07-21T11:41:16Z

the regenerated lockfiles dropped the libc fields on the litesvm Linux packages (they're present on main). Not breaking CI since the runners are glibc, but it can pull the wrong binary on musl/Alpine. Looks like it was regenerated with a pnpm other than the pinned 10.33.0. Can you redo them with:

corepack use pnpm@10.33.0
pnpm install --lockfile-only

dev-jodee

the comment above ^

NikkiAung · 2026-07-22T02:18:04Z

Fixed in the latest commit. The root cause was a stale pnpm store — pnpm was reading cached metadata that omitted the libc selectors instead of fetching them fresh from the registry.

Fix: pnpm store prune to clear stale cache entries, then deleted and regenerated each lockfile from scratch with pnpm@10.33.0 --lockfile-only. All litesvm platform packages now correctly record libc: [glibc] and libc: [musl].

dev-jodee

think all the typescript version upgrades should be removed, keep only the 5 pilot programs you mentions in the pr

dev-jodee · 2026-07-22T15:50:33Z

    "solana-bankrun": "^0.3.0",
    "ts-mocha": "^10.0.0",
-    "typescript": "^4.3.5"
+    "typescript": "^5.5.0"


Why is there a typescript change as well? seems like the lock files aren't generated even tho the typescript version changed

NikkiAung · 2026-07-23T04:47:57Z

Fixed — reverted typescript back to ^4.3.5 in all 5 pilot package.json files and regenerated the lockfiles. The TypeScript bump belongs in PR #633 and is no longer part of this diff.

greptile-apps · 2026-07-23T04:49:21Z

Want your agent to iterate on Greptile's feedback? Try greploops.

dev-jodee · 2026-07-23T13:08:37Z

@NikkiAung the 5 pilot package.jsons were fine (their lockfiles were regenerated). The problem is the other 34 package.json files in this PR (close-account, favorites, rent, realloc, transfer-sol, pda-rent-payer, program-derived-addresses, processing-instructions, repository-layout, cross-program-invocation, hello-solana/asm, create-account/asm, counter/mpl-stack, checking-accounts/native+pinocchio, account-data/native, counter/pinocchio, create-account/pinocchio, cross-program-invocation/pinocchio, plus the four outside basics/: nft-meta-data-pointer ×2, transfer-tokens/pinocchio, shank-and-solita)

Only the 5 pilot programs should be touched in this PR: basics/hello-solana/native basics/counter/native basics/account-data/pinocchio basics/checking-accounts/asm basics/create-account/native The TypeScript version bumps in the other 34 package.json files leaked in from an earlier iteration of this branch and are being reverted here per dev-jodee's feedback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

NikkiAung · 2026-07-24T01:45:37Z

@dev-jodee Fixed — those 34 extra package.json files are now reverted to main in the latest commit (5e26fde). The diff is now scoped to exactly the 5 pilot programs:

basics/hello-solana/native
basics/counter/native
basics/account-data/pinocchio
basics/checking-accounts/asm
basics/create-account/native

17 files total (package.json + pnpm-lock.yaml + tsconfig + test files for each pilot). Nothing outside those 5 directories is touched.

…ner (pilot) Replaces ts-mocha with `tsx --test` as the test runner for the first 5 pilot programs, removing the dead mocha layer that was present alongside node:test API imports. Changes per program: - package.json: swap `test` script to `tsx --test <file>`, drop mocha/ts-mocha/@types/mocha/chai/@types/chai devDeps, add tsx + @types/node - tsconfig: update `types` from ["mocha","chai"(,"node")] → ["node"] - hello-solana/native + counter/native: convert `import { assert } from "chai"` → `import assert from "node:assert"` (identical truthy semantics, no call-site edits) - pnpm-lock.yaml: regenerated per package to reflect new deps Pilots cover every variant: both tsconfig conventions (root / tests/), both runtimes (solana-bankrun / litesvm), all 3 CI workflows (native, pinocchio, asm), and all assertion styles (chai convert, bare throw, node:assert already, none). No CI workflow changes needed — tests are invoked via the `pnpm test` script that `build-and-test` already chains into. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The previous lockfiles were generated with a stale pnpm store that omitted the libc field for litesvm platform packages. Regenerated using pnpm@10.33.0 with a clean store (pnpm store prune) so libc: [glibc] and libc: [musl] are correctly recorded for musl/Alpine environments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…de:test runner Follow-up to the 5-program pilot (PR solana-foundation#636). Applies the same pattern to all remaining non-anchor native/pinocchio/asm programs in basics/: - package.json: test script → `tsx --test <file>`; drop mocha/ts-mocha/ @types/mocha/chai/@types/chai; add tsx ^4.22.0 + @types/node ^22.19.1 - tsconfig.json (or tests/tsconfig.test.json): types → ["node"] - pnpm-lock.yaml: regenerated per package 6 test files also needed structural edits: - cross-program-invocation/native + pinocchio: add `node:test` imports; rename it() → test() - hello-solana/asm + pinocchio: add node:test imports; rename it() → test(); convert chai import to node:assert - favorites/native: change mocha import → node:test; chai → node:assert; convert expect().to.equal/deep.equal → assert.strictEqual/deepStrictEqual; add beforeEach to node:test import - favorites/pinocchio: change mocha import → node:test (stub file) Anchor programs are intentionally excluded: anchor test uses mocha internally via `anchor test --validator legacy`, bypassing package.json scripts entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rom counter/native tsconfig counter/native has two tsconfig files; the root tsconfig.json was missed in the initial tsx migration, causing CI typecheck to fail with 'cannot find type definition for chai/mocha'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

NikkiAung requested a review from dev-jodee as a code owner July 21, 2026 05:30

greptile-apps Bot reviewed Jul 21, 2026

View reviewed changes

NikkiAung force-pushed the feat/node-test-runner branch from 81f9b32 to b898429 Compare July 21, 2026 05:37

NikkiAung mentioned this pull request Jul 21, 2026

feat(basics): migrate remaining 29 programs from ts-mocha to tsx + node:test runner #637

Open

4 tasks

dev-jodee requested changes Jul 21, 2026

View reviewed changes

NikkiAung force-pushed the feat/node-test-runner branch from b898429 to 52f74b4 Compare July 22, 2026 02:17

dev-jodee requested changes Jul 22, 2026

View reviewed changes

NikkiAung and others added 2 commits July 24, 2026 17:23

NikkiAung force-pushed the feat/node-test-runner branch from 5e26fde to 4190464 Compare July 25, 2026 00:27

Uh oh!

Conversation

NikkiAung commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Pilot programs (5) — chosen to cover all variants

Changes per program

Test plan

Uh oh!

greptile-apps Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

dev-jodee Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiAung Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiAung Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

dev-jodee commented Jul 21, 2026

Uh oh!

dev-jodee left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiAung commented Jul 22, 2026

Uh oh!

dev-jodee left a comment

Choose a reason for hiding this comment

Uh oh!

dev-jodee Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiAung commented Jul 23, 2026

Uh oh!

greptile-apps Bot commented Jul 23, 2026

Uh oh!

dev-jodee commented Jul 23, 2026

Uh oh!

NikkiAung commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NikkiAung commented Jul 21, 2026 •

edited

Loading

greptile-apps Bot commented Jul 21, 2026 •

edited

Loading