chore(ci-cd): publish to maven local does not require sign key - #82
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Gradle publishing convention to avoid requiring a signing key when publishing artifacts to the local Maven repository (~/.m2), while preserving signing for Maven Central releases in CI.
Changes:
- Makes publication signing conditional on the presence of the
signingInMemoryKeyGradle property. - Adds inline documentation explaining why unconditional signing breaks
publishToMavenLocal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Publishing artefacts to maven central required sign key. However publishing to local .m2 repository should not required the sign key.
Solution
signAllPublications() // Only sign when a key is actually configured (CI's release job sets this via // ORG_GRADLE_PROJECT_signingInMemoryKey). Signing unconditionally breakspublishToMavenLocal// for local development/testing, since no GPG key is available outside the release job. if (project.hasProperty("signingInMemoryKey")) { signAllPublications() }