fix: offset default value in AudioBufferQueueSourceNode.start#1189
Open
closetcaiman wants to merge 6 commits into
Open
fix: offset default value in AudioBufferQueueSourceNode.start#1189closetcaiman wants to merge 6 commits into
closetcaiman wants to merge 6 commits into
Conversation
closetcaiman
changed the title
closetcaiman
marked this pull request as draft
July 22, 2026 10:21
closetcaiman
marked this pull request as ready for review
July 23, 2026 14:22
mdydek
requested changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1181
resume(when)method inAudioBufferQueueSourceNode. Callingstartmultiple times now throwsInvalidStateError. The intented way to resume playback is to use theresume(when)method.Introduced changes
AudioBufferQueueSourceNode.startoffset. Previously it was set to-1which forced users to explicitly start the node with.start(0, 0)as calling.start()threwRangeErrordue tooffsetbeing negative by default.Checklist