Skip to content

feat: audio latency#1129

Merged
mdydek merged 38 commits into
mainfrom
feat/audio-latency
Jul 24, 2026
Merged

feat: audio latency#1129
mdydek merged 38 commits into
mainfrom
feat/audio-latency

Conversation

@closetcaiman

@closetcaiman closetcaiman commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #1104

⚠️ Breaking changes ⚠️

  • N/A

Introduced changes

Important

Identified race condition between oboe background thread (invoking onErrorAfterClose()) and any other thread that accesses mStream_ -> serialized it via locks (recursive_mutex exactly for clearer locking flow)
Audio Thread running onAudioReady does not require locks and thus stays consistent with no-locking policy

  • aligned AudioContext interface with spec by adding baseLatency and outputLatency
  • added inputLatency to AudioRecorder (React Native extension, not in spec)
  • all values are sourced from native APIs - AVAudioSession (iOS) and Oboe (Android)
    • platform differences in reported values are expected
  • updated docs for AudioContext and AudioRecorder with native source details

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@closetcaiman
closetcaiman requested a review from mdydek June 29, 2026 13:33
@closetcaiman closetcaiman added the feature New feature label Jul 9, 2026
maciejmakowski2003
maciejmakowski2003 requested changes Jul 10, 2026
View reviewed changes
Comment thread packages/audiodocs/docs/inputs/audio-recorder.mdx Outdated
Comment thread packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.h Outdated
Comment thread packages/react-native-audio-api/src/core/AudioRecorder.ts
Comment thread packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioContextHostObject.h
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp Outdated
maciejmakowski2003
maciejmakowski2003 requested changes Jul 14, 2026
View reviewed changes
Comment thread packages/audiodocs/docs/inputs/audio-recorder.mdx Outdated
mdydek
mdydek requested changes Jul 16, 2026
View reviewed changes
Comment thread packages/audiodocs/docs/core/audio-context.mdx Outdated
Comment thread packages/audiodocs/docs/core/audio-context.mdx Outdated
Comment thread ...native-audio-api/android/src/main/cpp/audioapi/android/core/utils/latency/LatencyMonitor.cpp Outdated
Comment thread ...t-native-audio-api/android/src/main/cpp/audioapi/android/core/utils/latency/LatencyMonitor.h Outdated
Comment thread ...t-native-audio-api/android/src/main/cpp/audioapi/android/core/utils/latency/LatencyMonitor.h Outdated
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp
@closetcaiman
closetcaiman requested a review from mdydek July 21, 2026 13:25
mdydek
mdydek requested changes Jul 23, 2026
View reviewed changes
Comment thread packages/react-native-audio-api/ios/audioapi/ios/core/IOSAudioPlayer.h Outdated
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp Outdated
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp Outdated
@closetcaiman
closetcaiman requested a review from mdydek July 24, 2026 08:39
@mdydek
mdydek merged commit d276254 into main Jul 24, 2026
9 checks passed
@mdydek
mdydek deleted the feat/audio-latency branch July 24, 2026 13:26
@closetcaiman closetcaiman mentioned this pull request Jul 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 requested changes
@mdydek mdydek mdydek approved these changes

Assignees

No one assigned

Labels

feature New feature Web API Spec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose AudioContext.baseLatency / outputLatency (Web Audio spec) for latency compensation

3 participants

@closetcaiman @mdydek @maciejmakowski2003