[Plugin] SofaCHOLMOD: Add plugin with a supernodal Cholesky direct solver (EigenCholmodSupernodalLLT)#6176
Open
fredroy wants to merge 8 commits into
Open
[Plugin] SofaCHOLMOD: Add plugin with a supernodal Cholesky direct solver (EigenCholmodSupernodalLLT)#6176fredroy wants to merge 8 commits into
fredroy wants to merge 8 commits into
Conversation
…y to SuiteSparse/CHOLMOD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new optional plugin SofaCHOLMOD providing a direct linear solver,
EigenCholmodSupernodalLLT, based on the supernodal sparse Cholesky factorization of CHOLMOD (SuiteSparse), wrapped via Eigen's CholmodSupport.The dependency on SuiteSparse/CHOLMOD is fully isolated in this plugin so it stays out of the core solvers.
On a ~15k-DOF FEM beam: ~8x speedup over SparseLDLSolver on macOS
Note1: BLAS (important for performance)
Since the factorization delegates to dense BLAS3, performance is dictated by the BLAS backing CHOLMOD, not by SOFA:
numThreadsData is provided to control this at runtime.Note2: CHOLMOD is double-precision only → enforced at configure time (
SOFA_FLOATING_POINT_TYPE=double).Note3: NOT TESTED ON WINDOWS (YET)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if