Skip to content

[LinearAlgebra] Factorize matrix bloc trait using concept#6122

Merged
fredroy merged 14 commits into
sofa-framework:masterfrom
alxbilger:matrixtrait
Jun 10, 2026
Merged

[LinearAlgebra] Factorize matrix bloc trait using concept#6122
fredroy merged 14 commits into
sofa-framework:masterfrom
alxbilger:matrixtrait

Conversation

@alxbilger

@alxbilger alxbilger commented May 22, 2026

Copy link
Copy Markdown
Contributor

Based on #6121

matrix_bloc_traits is now specialized for all types satisfying the constraint std::is_scalar_v, including long double, without duplicating each specialization.

Relevant commit: 090aa6a

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 22, 2026
@fredroy fredroy added the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label May 28, 2026
alxbilger added 2 commits June 3, 2026 16:55
# Conflicts:
#	Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/matrix_bloc_traits.h
@fredroy fredroy removed the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label Jun 9, 2026
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 10, 2026
@fredroy fredroy merged commit 7dd88a5 into sofa-framework:master Jun 10, 2026
17 checks passed
@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants