Skip to content

[All] In RequiredPlugin, use pluginName instead of name#6039

Merged
fredroy merged 3 commits into
sofa-framework:masterfrom
alxbilger:requiredpluginname
Apr 6, 2026
Merged

[All] In RequiredPlugin, use pluginName instead of name#6039
fredroy merged 3 commits into
sofa-framework:masterfrom
alxbilger:requiredpluginname

Conversation

@alxbilger

@alxbilger alxbilger commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

I used the following regular expression to find them:

RequiredPlugin(.*)name(?!.*pluginName)

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 19, 2026
@alxbilger

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the requiredpluginname branch from 7ff7e7e to 6471cb3 Compare March 30, 2026 07:04
Comment thread applications/plugins/image/examples/loadHDR.py Outdated
@fredroy

fredroy commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

A pass in Claude (check if missing cases, and consistencies of the modified files)

XML — examples/Validation/cantilever_beam/CantileverBeam_ElementFEMForceField.xml (MISSED)
This file has 15 <RequiredPlugin name="Sofa.Component..."/> entries that were not converted to pluginName=
 
All changes in the commit look correct, except for the loadHDR.py bug which is already fixed in 1182b6d

@fredroy fredroy force-pushed the requiredpluginname branch from 99dad0e to 93b3554 Compare April 6, 2026 00:23
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 6, 2026
@fredroy fredroy merged commit 25a096d into sofa-framework:master Apr 6, 2026
12 of 17 checks passed
@hugtalbot hugtalbot added this to the v26.06 milestone May 8, 2026
@bakpaul bakpaul changed the title [all] In RequiredPlugin, use pluginName instead of name [All] In RequiredPlugin, use pluginName instead of name Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants