Skip to content

Remove unused call cancellation state - #12

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
remove-call-cancellation
Aug 21, 2026
Merged

Remove unused call cancellation state#12
samuel-williams-shopify merged 1 commit into
mainfrom
remove-call-cancellation

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Summary

  • remove the unused Protocol::GRPC::Call cancellation flag
  • remove Call#cancel! and Call#cancelled?
  • remove their tests and stale design documentation
  • document the public API removal as a breaking change

The flag was not used to drive cancellation or any protocol behavior.

Verification

  • test suite passes
  • RuboCop: 56 files, no offenses
  • documentation coverage: 97/97 public definitions

@samuel-williams-shopify
samuel-williams-shopify merged commit 4fb0b27 into main Aug 21, 2026
40 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the remove-call-cancellation branch August 21, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant