Add shared memory segment store - #2
Merged
Merged
Conversation
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Async::Utilization::SegmentStorefor storing, reusing, growing, and reading schema-backed shared memory segmentsSegmentStore.openinitializefocused on acquired resources and store-internal stateThis moves the shared-memory ownership and reader-side primitive next to
Async::Utilization::Observer, allowing supervisor integrations to depend on a reusable utilization abstraction.Verification
bundle exec bake test(50 tests, 139 assertions)bundle exec rubocop(236 files, no offenses)bundle exec bake decode:index:coverage lib(39/39 public definitions)COVERAGE=PartialSummary bundle exec bake test(229/229 lines, 100% coverage)MRI 3.3, 3.4, 4.0, and head checks previously passed on Linux/macOS. The allowed-to-fail JRuby and TruffleRuby jobs retain the existing
IO::Buffermapping failures also present onmain.