Skip to content

Fixed checking for external type property on symbol #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adwsingh merged 1 commit into from
Jun 19, 2026
+3 −3
Merged

Fixed checking for external type property on symbol #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...egen-core/src/main/java/software/amazon/smithy/java/codegen/generators/EnumGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public final class EnumGenerator<T extends ShapeDirective<Shape, CodeGenerationC

@Override
public void accept(T directive) {
if (directive.symbol().getProperty(SymbolProperties.EXTERNAL_TYPE).isPresent()) {
if (directive.symbol().getProperty(SymbolProperties.EXTERNAL_TYPE).orElse(false)) {
// skip external types
return;
}
Expand Down
2 changes: 1 addition & 1 deletion ...core/src/main/java/software/amazon/smithy/java/codegen/generators/StructureGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public final class StructureGenerator<
public void accept(T directive) {
if (directive.shape().hasTrait(UnitTypeTrait.class) || directive.symbol()
.getProperty(SymbolProperties.EXTERNAL_TYPE)
.isPresent()) {
.orElse(false)) {
// Skip Unit structures or external types.
return;
}
Expand Down
2 changes: 1 addition & 1 deletion ...gen-core/src/main/java/software/amazon/smithy/java/codegen/generators/UnionGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public final class UnionGenerator

@Override
public void accept(GenerateUnionDirective<CodeGenerationContext, JavaCodegenSettings> directive) {
if (directive.symbol().getProperty(SymbolProperties.EXTERNAL_TYPE).isPresent()) {
if (directive.symbol().getProperty(SymbolProperties.EXTERNAL_TYPE).orElse(false)) {
// Skip external types.
return;
}
Expand Down