Conversation
|
👋 pszal, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
pszal
enabled auto-merge (squash)
June 26, 2026 14:21
kaleofduty
reviewed
Aug 3, 2026
kaleofduty
left a comment
kaleofduty
left a comment
Collaborator
There was a problem hiding this comment.
LGTM other than one nit
| if err != nil { | ||
| t.Fatalf("Decrypt: %v", err) | ||
| } | ||
| b, err := want.MarshalJSON() |
Collaborator
There was a problem hiding this comment.
nit: Would it make more sense to define a data structure that contains a DecyptionShare, then invoke json.Marshal/json.Unmarshal on it to make sure that the json package interacts correctly with how we defined the interface functions? One typically doesn't directly call MarshalJSON, it's mediated through the json package.
Same for other json tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes the following issues: