fix(cre): wire ChainWrite.TargetsLimit to non-EVM WriteReport capabilities by cawthorne · Pull Request #23257 · smartcontractkit/chainlink

cawthorne · 2026-07-28T15:04:54Z

Summary

ChainWrite.TargetsLimit in CRE settings was silently unthrottled for non-EVM chains. The callLimiters map in capability_executor.go only wired ChainWriteTargets to {"evm", "WriteReport"} — Aptos, Solana, and Stellar WriteReport calls bypassed the limiter entirely.

The gap

The lookup at capability_executor.go:101:

limiter, ok := c.callLimiters[capCall{name: capName, method: request.Method}]
if ok { /* apply limit */ }
// if !ok → limiter silently skipped

For an Aptos write, ParseID("aptos:ChainSelector:4457093679053095497@1.0.0") returns name="aptos". The map only had {"evm", "WriteReport"} — so ok=false and the call proceeded unchecked.

family	`WriteReport` exists?	In `callLimiters` (before)	In `callLimiters` (after)
`evm`	✅	✅	✅
`aptos`	✅	❌	✅
`solana`	✅	❌	✅
`stellar`	✅	❌	✅

The fix

Add new map entries — the limiter object (limiters.ChainWriteTargets) and settings schema (cresettings.chainWrite.TargetsLimit) already exist and are chain-family-agnostic:

		{"aptos", "View"}: limiters.ChainReadCalls,

		{"solana", "GetAccountInfoWithOpts"}:      limiters.ChainReadCalls,
		{"solana", "GetBalance"}:                  limiters.ChainReadCalls,
		{"solana", "GetBlock"}:                    limiters.ChainReadCalls,
		{"solana", "GetFeeForMessage"}:            limiters.ChainReadCalls,
		{"solana", "GetMultipleAccountsWithOpts"}: limiters.ChainReadCalls,
		{"solana", "GetSignatureStatuses"}:        limiters.ChainReadCalls,
		{"solana", "GetSlotHeight"}:               limiters.ChainReadCalls,
		{"solana", "GetTransaction"}:              limiters.ChainReadCalls,

		{"stellar", "GetLatestLedger"}: limiters.ChainReadCalls,
		{"stellar", "ReadContract"}:    limiters.ChainReadCalls,

		{"evm", "WriteReport"}:     limiters.ChainWriteTargets,
		{"aptos", "WriteReport"}:   limiters.ChainWriteTargets,
		{"solana", "WriteReport"}:  limiters.ChainWriteTargets,
		{"stellar", "WriteReport"}: limiters.ChainWriteTargets,

Production impact

Any production workflow writing to Aptos/Solana/Stellar has unlimited write targets today, regardless of ChainWrite.TargetsLimit in the org-level CRE settings. With this fix, TargetsLimit=0 correctly blocks all chain writes, not just EVM.

How discovered

While debugging fire-drill transmit_fault scenarios in chainlink-data-feeds. We investigated whether ChainWrite.TargetsLimit=0 could replace the bad-contract-address fault (hot-reloadable, no re-register), but found Aptos writes bypassed the limiter — leading to this fix.

Test plan

go test ./core/services/workflows/v2/... passes (verified locally)
Existing EVM write-limit tests still pass (no behavioral change for EVM)
Manual: set ChainWrite.TargetsLimit = 0 on an Aptos-targeted workflow, verify writes are now blocked (previously: writes succeeded)

github-actions · 2026-07-28T15:05:14Z

👋 cawthorne, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

github-actions · 2026-07-28T15:06:17Z

✅ No conflicts with other open PRs targeting develop

github-actions · 2026-07-28T15:06:25Z

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

trunk-io · 2026-07-28T15:19:46Z

Failed Test	Failure Summary	Logs
`TestTransfersController_TransferBalanceToLowError`	The test failed due to a low balance error during transfer.	Logs ↗︎

_{View Full Report ↗︎ ⋅ Docs}

cawthorne · 2026-07-28T16:08:28Z

This breaks the Stellar ReadContract test:
stellar.ReadContract: PerWorkflow.ChainRead.CallLimit limited for workflow[00c2f1c36d518944c52c54e87b8bc51ecf8792fb905244ecbb7f98ec8dbc6b88]: cannot use 16, limit is 15\""
Either a latent default limit or a test would need to be adjusted.

c.c. @yashnevatia @ilija42

cawthorne · 2026-07-30T10:30:47Z

This breaks the Stellar ReadContract test: stellar.ReadContract: PerWorkflow.ChainRead.CallLimit limited for workflow[00c2f1c36d518944c52c54e87b8bc51ecf8792fb905244ecbb7f98ec8dbc6b88]: cannot use 16, limit is 15\"" Either a latent default limit or a test would need to be adjusted.

c.c. @yashnevatia @ilija42

Added a new TOML for this test which bumps the CallLimit. May not be the leanest approach, open to feedback @yashnevatia @ilija42

ilija42

Why not just set the limit in the existing toml config?

cawthorne · 2026-07-30T10:36:33Z

Why not just set the limit in the existing toml config?

Happy to. I was just unsure if the existing one should be left alone. Will do that now.

cawthorne · 2026-07-30T10:40:08Z

Why not just set the limit in the existing toml config?

Done.

The callLimiters map in capability_executor.go only wired EVM capability methods to the ChainReadCalls and ChainWriteTargets limiters. Aptos, Solana, and Stellar read/write calls were silently unthrottled — the limiter lookup returned ok=false and the call proceeded unchecked, regardless of the ChainRead.CallLimit or ChainWrite.TargetsLimit settings. The settings schema (chainlink-common cresettings) already defines these limits as chain-family-agnostic per-workflow limits. The wiring just never connected them to non-EVM capability methods. Read methods added: aptos: View solana: GetAccountInfoWithOpts, GetBalance, GetBlock, GetFeeForMessage, GetMultipleAccountsWithOpts, GetSignatureStatuses, GetSlotHeight, GetTransaction stellar: GetLatestLedger, ReadContract Write methods added: aptos: WriteReport solana: WriteReport stellar: WriteReport All map to the same limiter objects already used for EVM (limiters.ChainReadCalls / limiters.ChainWriteTargets). Discovered while debugging fire-drill transmit_fault scenarios in chainlink-data-feeds: we investigated whether ChainWrite.TargetsLimit=0 could replace the bad-contract-address fault (hot-reloadable, no re-register), but found Aptos writes bypassed the limiter entirely.

cl-sonarqube-production · 2026-07-30T11:08:55Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

cawthorne requested a review from a team as a code owner July 28, 2026 15:04

product-security-plaid-production Bot requested a review from jmank88 July 28, 2026 15:05

cawthorne force-pushed the feature/add-non-evm-WriteReport-limits branch from 050ba19 to 4d694a8 Compare July 28, 2026 15:34

jmank88 previously approved these changes Jul 28, 2026

View reviewed changes

cawthorne dismissed jmank88’s stale review via d7f6b56 July 30, 2026 10:29

cawthorne requested review from a team as code owners July 30, 2026 10:29

product-security-plaid-production Bot requested review from cedric-cordenier and pavel-raykov July 30, 2026 10:29

ilija42 reviewed Jul 30, 2026

View reviewed changes

cawthorne force-pushed the feature/add-non-evm-WriteReport-limits branch from eebf489 to 04e939a Compare July 30, 2026 10:48

ilija42 approved these changes Jul 30, 2026

View reviewed changes

mchain0 approved these changes Jul 30, 2026

View reviewed changes

cawthorne added this pull request to the merge queue Jul 30, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2026

jmank88 approved these changes Jul 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cre): wire ChainWrite.TargetsLimit to non-EVM WriteReport capabilities - #23257

fix(cre): wire ChainWrite.TargetsLimit to non-EVM WriteReport capabilities#23257
cawthorne wants to merge 1 commit into
developfrom
feature/add-non-evm-WriteReport-limits

cawthorne commented Jul 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

trunk-io Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

cawthorne commented Jul 28, 2026

Uh oh!

cawthorne commented Jul 30, 2026

Uh oh!

ilija42 left a comment

Uh oh!

cawthorne commented Jul 30, 2026

Uh oh!

cawthorne commented Jul 30, 2026

Uh oh!

cl-sonarqube-production Bot commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

cawthorne commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

The gap

The fix

Production impact

How discovered

Test plan

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

trunk-io Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cawthorne commented Jul 28, 2026

Uh oh!

cawthorne commented Jul 30, 2026

Uh oh!

ilija42 left a comment

Choose a reason for hiding this comment

Uh oh!

cawthorne commented Jul 30, 2026

Uh oh!

cawthorne commented Jul 30, 2026

Uh oh!

cl-sonarqube-production Bot commented Jul 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cawthorne commented Jul 28, 2026 •

edited

Loading

trunk-io Bot commented Jul 28, 2026 •

edited

Loading