various cleanup - #523
Open
jmank88 wants to merge 1 commit into
Open
Conversation
Contributor
📊 API Diff Results
|
Contributor
📊 API Diff Results
|
Contributor
📊 API Diff Results
|
Contributor
📊 API Diff Results
|
jmank88
force-pushed
the
CRE-5694-cleanup
branch
from
August 14, 2026 02:04
4807abb to
40a4d8c
Compare
jmank88
force-pushed
the
CRE-5694-cleanup
branch
from
August 14, 2026 12:26
40a4d8c to
b279ef1
Compare
ibrajer
previously approved these changes
Aug 14, 2026
jmank88
force-pushed
the
CRE-5694-cleanup
branch
2 times, most recently
from
August 14, 2026 14:01
f8dbc3e to
72c5b96
Compare
RensR
reviewed
Aug 14, 2026
|
|
||
| [Transactions.AutoPurge] | ||
| Enabled = false | ||
| Threshold = 5 |
Contributor
There was a problem hiding this comment.
Why do we need to set default for it. Node won't start if the value is missing and not having a fallback requires chain integrator to define proper value.
Collaborator
Author
There was a problem hiding this comment.
Well we have 7 chains that do not set the threshold. Should they be customized individually instead?
jmank88
force-pushed
the
CRE-5694-cleanup
branch
2 times, most recently
from
August 14, 2026 14:50
725b5ea to
d28a0a1
Compare
jmank88
force-pushed
the
CRE-5694-cleanup
branch
from
August 14, 2026 15:14
d28a0a1 to
8c47bbc
Compare
jmank88
marked this pull request as ready for review
August 14, 2026 15:32
product-security-plaid-production
Bot
requested review from
Oozyx,
ilija42 and
yashnevatia
August 14, 2026 15:32
pavel-raykov
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CRE-5694