Safeguard FeeHistory Estimator - #515
Merged
Merged
Conversation
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the FeeHistoryEstimator against edge cases from eth_feeHistory responses and reduces the risk of bump operations blocking on refresh signaling.
Changes:
- Add a minimum
CacheTimeoutvalidation duringFeeHistoryEstimator.Start(). - Guard against
nilpercentile entries infeeHistory.Rewardwhen computing priority fee stats. - Make refresh signaling non-blocking by buffering
refreshChand using a best-effort send helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/gas/fee_history_estimator.go | Adds CacheTimeout validation, nil-reward handling, caps max dynamic fee fields, and switches refresh signaling to non-blocking behavior. |
| pkg/gas/fee_history_estimator_test.go | Updates tests to use t.Context() and adds a startup validation test for CacheTimeout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dimriou
enabled auto-merge (squash)
July 30, 2026 10:31
dhaidashenko
previously approved these changes
Jul 30, 2026
dimriou
disabled auto-merge
July 31, 2026 08:34
dimriou
marked this pull request as ready for review
July 31, 2026 12:59
amit-momin
approved these changes
Jul 31, 2026
dhaidashenko
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
feeHistory's rewards.CacheTimeoutcheck.maxFeePerGasandpriorityFeeThresholdupdates consistent - preventspriorityFeeThresholdbeing lower thanmaxFeePerGasat a given instance, which can trigger false positive connectivity errors.newNoMempoolBaseFeeBufferPercentagefor chains without a mempool i.e. Arbitrum, to prevent insufficient base fee errors.