Canton Config for EVM - #2202
Conversation
|
👋 stackman27, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
|
|
||
| fqConfig := mergeFeeQuoterDestChainConfig( | ||
| remoteAdapter.GetDefaultFeeQuoterDestChainConfig(localChainSelector, remoteChainSelector, remoteAdapter.GetChainFamilySelector()), | ||
| localAdapter.GetDefaultFeeQuoterDestChainConfig(localChainSelector, remoteChainSelector, remoteAdapter.GetChainFamilySelector()), |
There was a problem hiding this comment.
this should stay as the remote adapter. Basically Canton's adapter should feed EVM the configs EVM needs to configure Canton
| // what the defaults or user-supplied overrides contain. | ||
| fqConfig.ChainFamilySelector = remoteAdapter.GetChainFamilySelector() | ||
|
|
||
| defaults := remoteAdapter.GetDefaultRemoteChainConfig(localChainSelector, remoteChainSelector) |
There was a problem hiding this comment.
We still need this line. It's the job of the counterpart to give the "local" the right config to configure itself
There was a problem hiding this comment.
Because, imagine when Solana or Aptos needs to hook up to Canton. They shouldn't have any Canton specific details
2 participants
No description provided.