fix(commit): make observations non-blocking on stuck ops (#2193) - #2197
Draft
FelixFan1992 wants to merge 1 commit into
Draft
fix(commit): make observations non-blocking on stuck ops (#2193)#2197FelixFan1992 wants to merge 1 commit into
FelixFan1992 wants to merge 1 commit into
Conversation
FelixFan1992
commented
Jul 15, 2026
FelixFan1992
commented
Contributor
- fix(commit): make observations non-blocking on stuck ops
- Replace the free WaitForAllNoErrOperations (which ended in an unconditional wg.Wait) with a stateful asynclib.Runner whose WaitForAll returns on timeout, so one operation that ignores its context can no longer hang the whole Observation / OCR round.
- Add a per-operation in-flight guard: an op whose previous invocation is still running is skipped rather than re-spawned, bounding goroutines to the number of distinct ops instead of accumulating one stuck goroutine per round.
- Return only operations that completed this round; a missing result degrades to its zero value (empty), and a late result from an abandoned goroutine is discarded rather than served, so consensus never acts on stale data.
- lint
* fix(commit): make observations non-blocking on stuck ops - Replace the free WaitForAllNoErrOperations (which ended in an unconditional wg.Wait) with a stateful asynclib.Runner whose WaitForAll returns on timeout, so one operation that ignores its context can no longer hang the whole Observation / OCR round. - Add a per-operation in-flight guard: an op whose previous invocation is still running is skipped rather than re-spawned, bounding goroutines to the number of distinct ops instead of accumulating one stuck goroutine per round. - Return only operations that completed this round; a missing result degrades to its zero value (empty), and a late result from an abandoned goroutine is discarded rather than served, so consensus never acts on stale data. * lint
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.