add mcms qualifier for fast curse - #2170
Open
FelixFan1992 wants to merge 1 commit into
Open
Conversation
FelixFan1992
requested review from
AmrMohamedRezk,
agusaldasoro,
b-gopalswami,
carte7000,
chris-de-leon-cll,
makramkd and
matYang
July 2, 2026 15:17
|
👋 FelixFan1992, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
carte7000
reviewed
Jul 29, 2026
| ChainSelector uint64 | ||
| // MCMSQualifier is the proposal-level MCMS qualifier from the changeset config. | ||
| // Sui uses it to choose fast CurserCap curse vs slow OwnerCap curse encoding. | ||
| MCMSQualifier string |
Contributor
There was a problem hiding this comment.
@FelixFan1992 can you document why Sui can't use a different MCM for owner curse vs specific curser role
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.