feat: add --app flag support to slack create for linking existing apps#565
Open
srtaalej wants to merge 1 commit into
Open
feat: add --app flag support to slack create for linking existing apps#565srtaalej wants to merge 1 commit into
srtaalej wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 71.66% 71.63% -0.04%
==========================================
Files 226 227 +1
Lines 19115 19200 +85
==========================================
+ Hits 13699 13754 +55
- Misses 4209 4230 +21
- Partials 1207 1216 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
slack createnow accepts the--appflag alongside--templateto scaffold a project and automatically link it to an existing app by fetching its manifest from App Settings.Summary
This PR adds
--app [ID]support toslack create. When used with--template, the CLI will:apps.manifest.export)manifest.jsonThe
--nameflag takes precedence over the remote manifest's display name when both are provided.Using
--appwithout--templatereturns an error with guidance.Example:
slack create my-project -t slack-samples/bolt-js-starter-template --app A0123456789Preview
📂 Project Create Cloning template slack-samples/bolt-js-starter-template To path ~/programming/slack-cli/my-project 📦 Project Dependencies Added my-project/.slack Added my-project/.slack/.gitignore Added my-project/.slack/config.json Added my-project/.slack/hooks.json Updated app manifest source to "project" (local) Added package @slack/cli-hooks@1.3.2 Installed dependencies using npm install 📋 Next Steps Learn more about the project in the README.md Change into your project with cd my-project/ Start developing and see changes in real-time with slack runTesting
Manual verification:
./bin/slack create my-project -t slack-samples/bolt-js-starter-template --app <real-app-id>.slack/apps.dev.jsoncontains linked app with correct team/app IDsmanifest.jsonmatches remote app's manifest--appwithout--templatereturns helpful error--nameoverrides manifest display name when providedNotes
manifest.json. A future PR will implement git-style merging where template and remote manifestsare combined.
Requirements