Skip to content

fix(mcp-client): make slackbot MCP examples pass ruff 0.16 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 1 commit into from
Aug 1, 2026
Merged

fix(mcp-client): make slackbot MCP examples pass ruff 0.16 #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ai/slackbot-mcp-client/no-auth/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ httpx2==2.9.1
mcp==1.28.1
mypy==2.3.0
pytest==9.1.1
ruff==0.15.22
ruff==0.16.0
slack_bolt==1.30.0
slack_cli_hooks==0.3.0
slack_sdk==3.43.0
Expand Down
2 changes: 1 addition & 1 deletion ai/slackbot-mcp-client/no-auth/tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
)
_mock_auth.start()

from src.app import app # noqa: E402
from src.app import app

SIGNING_SECRET = "test_signing_secret"

Expand Down
2 changes: 1 addition & 1 deletion ai/slackbot-mcp-client/rich-responses/mcp-apps/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ httpx2==2.9.1
mcp==1.28.1
mypy==2.3.0
pytest==9.1.1
ruff==0.15.22
ruff==0.16.0
slack_bolt==1.30.0
slack_cli_hooks==0.3.0
slack_sdk==3.43.0
Expand Down
2 changes: 1 addition & 1 deletion ai/slackbot-mcp-client/rich-responses/mcp-apps/tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
)
_mock_auth.start()

from src.app import app # noqa: E402
from src.app import app

SIGNING_SECRET = "test_signing_secret"

Expand Down
2 changes: 1 addition & 1 deletion ai/slackbot-mcp-client/slack-identity/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ httpx2==2.9.1
mcp==1.28.1
mypy==2.3.0
pytest==9.1.1
ruff==0.15.22
ruff==0.16.0
slack_bolt==1.30.0
slack_cli_hooks==0.3.0
slack_sdk==3.43.0
Expand Down
3 changes: 2 additions & 1 deletion ai/slackbot-mcp-client/slack-identity/src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from slack_bolt import App
from slack_bolt.adapter.starlette import SlackRequestHandler
from slack_bolt.oauth.oauth_settings import OAuthSettings
from slack_sdk.errors import SlackApiError
from slack_sdk.oauth.installation_store import FileInstallationStore
from slack_sdk.oauth.state_store import FileOAuthStateStore
from slack_sdk.signature import SignatureVerifier
Expand Down Expand Up @@ -71,7 +72,7 @@ async def get_profile_card(
profile = (result["user"] or {}).get("profile")
if not profile:
raise ValueError("No profile found")
except Exception:
except (SlackApiError, ValueError, KeyError):
return CallToolResult(
content=[
TextContent(
Expand Down
2 changes: 1 addition & 1 deletion ai/slackbot-mcp-client/slack-identity/tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
os.environ["SLACK_CLIENT_ID"] = "111.222"
os.environ["SLACK_CLIENT_SECRET"] = "client_secret"

from src.app import app # noqa: E402
from src.app import app

SIGNING_SECRET = "test_signing_secret"
TEAM_ID = "T0001"
Expand Down