Fix mixed tab/space indentation introduced in PR #1's container-validation-annotation-leak fix - #2
Draft
jaipilot[bot] wants to merge 1 commit into
Conversation
…ation-annotation-leak fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #1 mirrors upstream springdoc-openapi#3322, fixing a bug where a
@Pattern(or other) validation annotation on oneListquery parameter's element type leaked into siblingListparameters' item schemas. The functional fix lives inGenericParameterService#resolveTypeAndTypeAnnotationsForParameter, with supporting readability edits inAbstractRequestServiceand a javadoc fix inDelegatingMethodParameter, plus a new/personsendpoint and updatedapp267.jsonfixtures proving the fix.What this companion does
This is a bounded, behavior-preserving cleanup pass on top of the exact PR head:
SpringDocApp267Test(v30 and v31) already characterizes the changed production paths (parameter-object field annotations and direct sibling list parameter annotations) and ran it unmodified before and after the edit with identical results.GenericParameterService.javaindented with spaces instead of the file's tab convention, and reformatted bothHelloController.javatest fixtures (v30/v31app267) from tabs to 4-space indentation, inconsistent with every sibling file in the same packages (e.g.PersonQueryFilter.java). Restored tab indentation in all three files. Verified withgit diff -wthat this is a pure whitespace change.Stream.concat(...).toList()replacing anArrays.asList(...)call) resolves a handful of annotations once per OpenAPI parameter during spec generation, not a hot path; no measurable optimization was justified.Verification
mvn -q -pl springdoc-openapi-starter-common,springdoc-openapi-starter-webmvc-api -am test -Dtest=SpringDocApp267Test -Dsurefire.failIfNoSpecifiedTests=false— 2/2 passed before and after.mvn -q -pl springdoc-openapi-starter-common,springdoc-openapi-starter-webmvc-api -am clean verify -DskipITs— full module verify green: common 32/32, webmvc-api 646/646.Limitations
full(all-module) build was run; verification is scoped to the two modules the original PR changes and their reactor dependencies, consistent with the bounded-improvement mandate.app267.json(space-before-colon / missing trailing newline versus most sibling fixtures) was investigated but left unchanged: JSONAssert compares these fixtures semantically, several other pre-existing fixtures in the repository already use the same non-standard formatting, and reformatting was judged cosmetic noise rather than a proven defect within this bounded pass.Generated by JAIPilot Cloud for #1 from Anthropic session
sesn_01HedWhaqk3Kss8hYU3LUyXC.