Skip to content

fix(tables): reduce column header chevron size and fix sidebar shadow bleed#4800

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/tabl-ui
May 29, 2026
Merged

fix(tables): reduce column header chevron size and fix sidebar shadow bleed#4800
waleedlatif1 merged 1 commit into
stagingfrom
fix/tabl-ui

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Reduced column header chevron (sort indicator) from 14px to 10px — was too prominent relative to the column type icon
  • Fixed table sidebars (workflow, column config, enrichments) bleeding their box-shadow onto the table content when closed — shadow is now only applied when the panel is open

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cursor
Copy link
Copy Markdown

cursor Bot commented May 29, 2026

PR Summary

Low Risk
Cosmetic CSS-only changes to table headers and sidebar open/closed classes; no API, auth, or data logic.

Overview
Two small table UI fixes: column header polish and right-edge panel shadow behavior.

The column options chevron in column-header-menu is shrunk from 14px to 10px so it reads less loudly next to the column type icon.

For column config, enrichments, and workflow sidebars, shadow-overlay is no longer always applied on the sliding <aside>. It is only added when the panel is open (translate-x-0), so the off-screen translated panel does not cast a box shadow onto the grid while closed.

Reviewed by Cursor Bugbot for commit 2eaaf0f. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

This PR contains two small, focused UI fixes for the tables feature: the column header sort chevron is downsized for better visual balance, and all three table sidebars (column config, enrichments, workflow) have their shadow-overlay class gated behind the open boolean to prevent the shadow from bleeding into the table content while the panel is off-screen.

  • Shadow bleed fix (column-config-sidebar, enrichments-sidebar, workflow-sidebar): shadow-overlay is moved from the unconditional base class to the open ? '... shadow-overlay' : '...' branch, so no shadow is painted when the panel is translated fully off-screen.
  • Chevron resize (column-header-menu): ChevronDown reduced from size-[14px] to size-[10px] to avoid the sort indicator visually dominating the column type icon.

Confidence Score: 5/5

Safe to merge — all four changes are minimal, isolated CSS class adjustments with no logic or state management impact.

Both fixes are straightforward: the shadow class is gated correctly behind the open flag across all three sidebars, and the chevron resize is a single Tailwind utility swap. No shared state, no data paths, and no API calls are touched.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsx Moves shadow-overlay into the open-conditional class so the shadow is only rendered when the panel is visible.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/enrichments-sidebar/enrichments-sidebar.tsx Same shadow-bleed fix as column-config-sidebar: shadow-overlay is now gated on open.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/workflow-sidebar/workflow-sidebar.tsx Same shadow-bleed fix applied consistently to the workflow sidebar.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/headers/column-header-menu.tsx ChevronDown icon reduced from size-[14px] to size-[10px] for better visual proportion.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Sidebar rendered] --> B{open?}
    B -- true --> C[translate-x-0\n+ shadow-overlay applied]
    B -- false --> D[translate-x-full\nno shadow]
    C --> E[Panel visible with shadow]
    D --> F[Panel off-screen, no shadow bleed]
Loading

Reviews (1): Last reviewed commit: "fix(tables): reduce column header chevro..." | Re-trigger Greptile

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 29, 2026 10:42pm

Request Review

@waleedlatif1 waleedlatif1 merged commit 925dd87 into staging May 29, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/tabl-ui branch May 29, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant