[puppetsync] Add a REFERENCE.md freshness check to PR tests - #133
Closed
silug wants to merge 1 commit into
Closed
Conversation
This patch updates pr_tests.yml from the reconciled puppetsync template, whose `reference` job now fails when REFERENCE.md is out of sync with the module's strings docs (`rake validate:strings`), and regenerates REFERENCE.md so the new check starts green. Repo-specific `jobs.acceptance` blocks are preserved as-is.
Contributor
Author
|
Closing: this repo is a Ruby gem with a fully custom pr_tests.yml, but puppetsync classified it as a Puppet module (it carries a pupmod-shaped metadata.json alongside its gemspec) and flattened the workflow into the module template. Fixed in simp/puppetsync#58 by detecting the gemspec first — this repo will no longer be targeted by module-template syncs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates pr_tests.yml from the reconciled puppetsync
template, whose
referencejob now fails when REFERENCE.md is outof sync with the module's strings docs (
rake validate:strings),and regenerates REFERENCE.md so the new check starts green.
Repo-specific
jobs.acceptanceblocks are preserved as-is.