Include Enumerable in Collection (#each_with_object etc.)

[jaevans]

Problem

ComplianceEngine::Collection (and subclasses Ces, Checks, Controls, Profiles) define #each but do not include Enumerable, so the standard Enumerable methods raise on every collection:

ces.each_with_object({}) { |(name, ce), acc| ... }
# => NoMethodError: undefined method 'each_with_object' for an instance of ComplianceEngine::Ces

A downstream consumer building an OVAL-id → CE reverse index with ces.each_with_object({}) crashed on this — the object walks like an enumerable (#each, #to_h, #select, #reject) but isn't one. See #127.

Fix

include Enumerable in ComplianceEngine::Collection. Because the class defines #each (yielding [name, component] pairs via to_h.each), this fills in #each_with_object, #map, #reduce, #find, #count, etc. for all collection types.

The explicit hash-like methods (#select, #reject, #keys) are defined on the class, so they shadow Enumerable's and keep returning Collections rather than Arrays (the behavior from #37) — verified by a test.

Tests

spec/classes/compliance_engine/ces_spec.rb gains an Enumerable interface group:

• each_with_object over [name, component] pairs (the regression),
• #map / #find,
• #select / #reject still return Collections (no regression from the mixin).

bundle exec rspec spec/classes/compliance_engine/{ces,collection,checks,controls,component,ce}_spec.rb → 50 examples, 0 failures; RuboCop clean.

Fixes #127

[Copilot]

Pull request overview

This PR makes ComplianceEngine::Collection (and therefore Ces, Checks, Controls, Profiles) a proper Ruby Enumerable by mixing in Enumerable, enabling standard methods like #each_with_object, #map, and #find when #each is defined.

Changes:

• Add include Enumerable to ComplianceEngine::Collection.
• Add RSpec coverage ensuring Enumerable methods work and that #select/#reject still return Collections.
• Document the behavior change in CHANGELOG.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
lib/compliance_engine/collection.rb	Mixes in Enumerable to provide the standard enumerable interface based on existing #each.
spec/classes/compliance_engine/ces_spec.rb	Adds regression + interface tests for Enumerable behavior and Collection-returning #select/#reject.
CHANGELOG.md	Notes the new Enumerable support for collections.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.