Skip to content

perf: skip grapheme regex for ASCII in utf8_clusters #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AmitMY wants to merge 1 commit into from
Closed

perf: skip grapheme regex for ASCII in utf8_clusters #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion complex_tokenization/graphs/units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def utf8(s: str) -> GraphVertex:


def utf8_clusters(s: str) -> GraphVertex:
clusters = regex.findall(r'\X', s)
# ASCII has no multi-codepoint grapheme clusters, so skip the \X regex.
clusters = list(s) if s.isascii() else regex.findall(r'\X', s)
nodes = []
for cluster in clusters:
handler = _get_handler(cluster)
Expand Down
Loading