SG-43456 [Part1] Add MEDM abstractions and utilities#137
SG-43456 [Part1] Add MEDM abstractions and utilities#137carlos-villavicencio-adsk wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 19.72% 15.48% -4.24%
==========================================
Files 35 42 +7
Lines 2794 3558 +764
==========================================
Hits 551 551
- Misses 2243 3007 +764
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carlos-villavicencio-adsk
changed the title
chenm1adsk
left a comment
chenm1adsk
left a comment
There was a problem hiding this comment.
Left some small comments and other looks good to me.
| """Background-thread worker: resolve URL then download bytes.""" | ||
| # 1. Resolve the thumbnail URL (hits the API at most once per revision). | ||
| url = self._url_cache.get(revision_id) | ||
| if url is None and revision_id not in self._url_cache: |
There was a problem hiding this comment.
Is this just equivalent to if revision_id not in self._url_cache?
There was a problem hiding this comment.
I believe we're checking the url value as well because it can actually contain a cached value.
There was a problem hiding this comment.
Isn't that url = self._url_cache.get(revision_id)? so if revision_id not in self._url_cache url is None?
2 participants
Base branch for tk-multi-loader2 v2.0.0
MEDM Abstractions
Classes to represent models and required utilities. We will consider moving them into a directory to improve code-organization
TODO
Nothing, this PR doesn't introduce breaking changes.
ℹ️ This should not affect or break the loader functionality.