Move to URL instead of CURL - #3
Conversation
Curl is not an emacs package, this is removed.
|
@ethanmoss1 thanks for putting this together and making it an Emacs only package, I love that. I won't be able to test it for a couple days but I'm on-board with merging it and going this direction. I'll test and merge ASAP. Thanks again! |
|
Oh no, thank you! Especially for doing most of the work! It was fun learning the URL package/lib. I might tackle some of the long-term goals soon, so I'll create a pull request when I've had a go. Any issues just shout and I'll get them changed ready for merging. |
This upsets Elpaca as it trys to install url
The function can now check inputs as well as change priority on the message.
The priority should be 1 to 5. and now the checks use a known good string or number
Also fixed some comments and bugs Added a check on the inputs
ntfy--publish-message: work now with the tags ntfy-message-*: these functions all have the keys removed ntfy--check-inputs: regex updated
shombando
left a comment
shombando
left a comment
There was a problem hiding this comment.
@ethanmoss1 this is so great! You have totally surpassed my original foundation. I have a couple requests for documentation updates (needed before merge) and a suggestion around emoji-list (for consideration, not merge blocker).
I'd like to invite you to be a maintainer of this project if you're willing. After this merge is done, I'll update the docs to point to Github as the canonical source of the package so you can make merges as a maintainer here.
Thanks for all the great updates and your immense patience.
| (setopt ntfy-server "http://ntfy.domain.com" | ||
| ntfy-topic "emacs" | ||
| ntfy-title "Notification from emacs" | ||
| ntfy-tags "purple_circle,loudspeaker" |
There was a problem hiding this comment.
@ethanmoss1 I think this needs to be
ntfy-tags '("purple_circle" "loudspeaker")
| :config (setopt ntfy-server "https://ntfy.sh" | ||
| ntfy-topic "mytopic" | ||
| ntfy-header "Notification from emacs" | ||
| ntfy-tags "purple_circle,loudspeaker" |
There was a problem hiding this comment.
Same change here:
ntfy-tags '("purple_circle" "loudspeaker")
|
|
||
|
|
||
| ;;;--- Internal Functions | ||
| (defun ntfy--interactive-emoji-selector () |
There was a problem hiding this comment.
@ethanmoss1 this is really nice functionality, love it. I do wonder though if it makes sense to maintain an emoji list in the project that will be out of sync with both ntfy and emacs? Is there a way to invoke emacs built-in emoji-search?
2 participants
Bumped version to 2 as this requires a different library and no need for CURL.
Fixes issue #1, This stops package.el, elpaca and straight from trying to find an emacs package called curl.
If we want i can tackle #2 ?