Fix deprecation warnings#242
Open
mandre wants to merge 5 commits into
Open
Conversation
import_role is resolved statically at parse time by ansible-playbook --syntax-check. The redhat-subscription role is git-cloned at runtime and the ansible-lint mock only stubs tasks/main.yaml, so tasks_from: unregister.yml causes a syntax-check failure in CI. include_role is dynamic and skipped during --syntax-check, avoiding the failure while being semantically equivalent here (the task is already guarded by a conditional block).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be more, this is just a first batch of deprecation warning fixes.