Fix container registry credentials not passed when rhsm is disabled#240
Open
mandre wants to merge 1 commit into
Open
Fix container registry credentials not passed when rhsm is disabled#240mandre wants to merge 1 commit into
mandre wants to merge 1 commit into
Conversation
ContainerImageRegistryCredentials and ContainerImageRegistryLogin were
gated behind {% if rhsm_enabled %}, so when using the rhos-release path
they were never rendered into standalone_parameters.yaml. This caused
TripleO to fail pulling container images with an authentication error,
even though podman login succeeded separately.
Decouple the credentials block from rhsm_enabled and gate it on
registers being defined instead, so credentials are passed to TripleO
whenever registries are configured regardless of subscription method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContainerImageRegistryCredentials and ContainerImageRegistryLogin were gated behind {% if rhsm_enabled %}, so when using the rhos-release path they were never rendered into standalone_parameters.yaml. This caused TripleO to fail pulling container images with an authentication error, even though podman login succeeded separately.
Decouple the credentials block from rhsm_enabled and gate it on registers being defined instead, so credentials are passed to TripleO whenever registries are configured regardless of subscription method.