Fix broken conditionals: replace var|string with proper boolean checks#239
Open
mandre wants to merge 1 commit into
Open
Fix broken conditionals: replace var|string with proper boolean checks#239mandre wants to merge 1 commit into
mandre wants to merge 1 commit into
Conversation
Newer Ansible versions (2.17+) require 'when' conditionals to evaluate
to a boolean, not a truthy string. The |string filter converts a value
to its string representation but does not produce a boolean result.
Replace all 'var|string' conditionals with
'var | default('', true) | length > 0' (positive checks) and
'var | default('', true) | length == 0' (negated checks) to produce
proper boolean results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer Ansible versions (2.17+) require 'when' conditionals to evaluate to a boolean, not a truthy string. The |string filter converts a value to its string representation but does not produce a boolean result.
Replace all 'var|string' conditionals with
'var | default('', true) | length > 0' (positive checks) and 'var | default('', true) | length == 0' (negated checks) to produce proper boolean results.