Fix PDF page dimensions for rendered documents#4
Open
lhr0909 wants to merge 1 commit into
Open
Conversation
4b00c01 to
db59ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift testin CI so the regression test is exercised on pull requestsFindings
While investigating #3, I found that
PDFRendererwas usingpageSize.size(atDPI: .print)for the Core Graphics PDF media box. Since.printis 300 DPI, A4 becomes 2480.31 × 3507.87 PDF units. PDF viewers interpret media box units as PDF points where 1 inch = 72 points, so the physical page is shown as roughly 875 × 1237.5 mm — close to A0.Changing only the view/display DPI does not affect that physical page size because the oversized media box is created before rendering. The fix is to use 72-point PDF units for the page box and keep print DPI as a separate rasterization-quality concern.
Fixes #3.
Validation
swift test --configuration release