Fix Modbus_win.cpp compilation under global WIN32_LEAN_AND_MEAN#16
Open
ros-dorian wants to merge 1 commit into
Open
Fix Modbus_win.cpp compilation under global WIN32_LEAN_AND_MEAN#16ros-dorian wants to merge 1 commit into
ros-dorian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again @serhmarch :)
I want to also surface that when a global
WIN32_LEAN_AND_MEANcompiler definition is defined in CMake, including the library withadd_subdirectoryin CMake causes a compilation error inModbus_win.cpp.Description
When
WIN32_LEAN_AND_MEANis defined, some headers normally included withWindows.hget discarded. Under this rule, there are two Windows headers missing inModbus_win.cppwhich causes the build to fail.Solution
In order to be completely agnostic to compiler definitions coming from the outside world, we can define it explicitly and include the missing headers. This ensures that the file will build fine regardless of the initial state.
Environment
ModbusLib v0.5.0
Windows 11, Visual Studio 2026