UIK 5438/rewrite base components to ns#3042
Open
slizhevskyv-semrush wants to merge 11 commits into
Open
Conversation
Contributor
Author
There was a problem hiding this comment.
@ilyabrower I leave Collapse/FadeInOut/FadeInOut/Scale/Slide within NSAnimation namespace (we had similar approach with feedback-form, but it were private components). Let me know if it's feasible to separate each component to it's own namespace.
Contributor
There was a problem hiding this comment.
Let's leave them in NSAnimation
ilyabrower
reviewed
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Let's leave them in NSAnimation
| return sstyled(style)( | ||
| <SCollapse | ||
| // `ref` is overriden by spread props. | ||
| // @ts-ignore |
| return sstyled(style)( | ||
| <Animation | ||
| // `ref` is overriden by spread props. | ||
| // @ts-ignore |
| return sstyled(style)( | ||
| <Animation | ||
| // `ref` is overriden by spread props. | ||
| // @ts-ignore |
| return sstyled(style)( | ||
| <Animation | ||
| // `ref` is overriden by spread props. | ||
| // @ts-ignore |
| return sstyled(style)( | ||
| <Animation | ||
| // `ref` is overriden by spread props. | ||
| // @ts-ignore |
| setTimeout(() => { | ||
| if (activeRef.current) return; | ||
| if (!isFocusInside(popperRef.current) && document.activeElement !== document.body) return; | ||
| if (popperRef.current === null || !isFocusInside(popperRef.current) && document.activeElement !== document.body) return; |
Contributor
There was a problem hiding this comment.
Maybe we should move the first check to the first if statement? First check if the link exists, and then all the other logic?
| Content: typeof Flex; | ||
| Addon: NSBox.Component; | ||
| Content: NSFlex.Component; | ||
| Text: typeof Text; |
slizhevskyv-semrush
requested review from
Valeria-Zimnitskaya
and removed request for
j-mnizhek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/animation
Fixed
NSAnimationnamespace.@semcore/ellipsis
Fixed
NSEllipsisnamespace.@semcore/flex-box
Fixed
NSBox/NSFlex/NSInvalidStateBox/NSScreenReaderOnlynamespaces.@semcore/grid
Fixed
NSGridnamespace.@semcore/hint
Fixed
NSHintnamespace.@semcore/neighbor-location
Fixed
NSNeighborLocationnamespace.@semcore/outside-click
Fixed
NSOutsideClicknamespace.@semcore/popper
Fixed
NSPoppernamespace.@semcore/portal
Fixed
NSPortalnamespace.@semcore/scroll-area
Fixed
NSScrollAreanamespace.Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: