Skip to content

[UIK-5351][theme] Add more variables to theme#3039

Open
j-mnizhek wants to merge 14 commits into
release/v17from
UIK-5351/add-more-variables-to-theme
Open

[UIK-5351][theme] Add more variables to theme#3039
j-mnizhek wants to merge 14 commits into
release/v17from
UIK-5351/add-more-variables-to-theme

Conversation

@j-mnizhek

@j-mnizhek j-mnizhek commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Changelog

@semcore/theme

Added

  • 81 new semantic variables
  • fallbacks for 12 renamed variables

Motivation and Context

  • Added 83 new variables to support upcoming changes and updates in the components styles
  • Added TODO comments to styles of some components
  • Updated variable name in the Tooltip example with custom background color (documentation)

How has this been tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@j-mnizhek j-mnizhek marked this pull request as ready for review July 2, 2026 16:21
ilyabrower
ilyabrower reviewed Jul 3, 2026
View reviewed changes
Comment thread semcore/base-components/src/components/hint/style/hint.shadow.css Outdated
Comment thread semcore/base-trigger/src/style/base-trigger.shadow.css
Comment thread semcore/button/src/component/Button/button.shadow.css
Comment thread semcore/button/src/component/Button/button.shadow.css Outdated
Comment thread semcore/checkbox/src/style/checkbox.shadow.css
Comment thread semcore/slider/src/style/slider.shadow.css Outdated
Comment thread semcore/slider/src/style/slider.shadow.css Outdated
Comment thread semcore/tag/src/style/tag.shadow.css
Comment thread semcore/tooltip/src/style/tooltip.shadow.css
Comment thread semcore/wizard/src/style/wizard.shadow.css
ilyabrower
ilyabrower reviewed Jul 3, 2026
View reviewed changes
Comment thread tools/theme/src/theme.ts Outdated
@j-mnizhek j-mnizhek removed the request for review from Valeria-Zimnitskaya July 3, 2026 14:14
@Valeria-Zimnitskaya

Valeria-Zimnitskaya commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@j-mnizhek @ilyabrower i found a bug here
Disappeared stars on feedback-rating, could you please tae a look and fix

Here how it looks now:
Screenshot 2026-07-07 at 12 15 06

@j-mnizhek j-mnizhek marked this pull request as draft July 7, 2026 12:13
@j-mnizhek

j-mnizhek commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@j-mnizhek i found a bug here Disappeared stars on feedback-rating, could you please tae a look and fix

I fixed this, the reason: I was experimenting with moving some old variables to the control group (as Ilia proposed) and forgot to mark it as deprecated
image

@j-mnizhek j-mnizhek marked this pull request as ready for review July 7, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment