Skip to content

Backport release/v6.6: Disable mempool traffic in freeze mode - #4006

Merged
masih merged 2 commits into
release/v6.6from
backport-3990-to-release/v6.6
Aug 25, 2026
Merged

Backport release/v6.6: Disable mempool traffic in freeze mode#4006
masih merged 2 commits into
release/v6.6from
backport-3990-to-release/v6.6

Conversation

@seidroid

@seidroid seidroid Bot commented Aug 25, 2026

Copy link
Copy Markdown

Backport of #3990 to release/v6.6.

@seidroid seidroid Bot added the backport label Aug 25, 2026
@seidroid seidroid Bot assigned masih Aug 25, 2026
@seidroid

seidroid Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-3990-to-release/v6.6
git worktree add --checkout .worktree/backport-3990-to-release/v6.6 backport-3990-to-release/v6.6
cd .worktree/backport-3990-to-release/v6.6
git reset --hard HEAD^
git cherry-pick -x 50e1129ebfc92487f59067d13daca22c26bcb4b1
git push --force-with-lease

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 25, 2026, 1:45 PM

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.18%. Comparing base (869b849) to head (3b3351e).

Files with missing lines Patch % Lines
sei-tendermint/node/node.go 77.77% 1 Missing and 1 partial ⚠️
sei-tendermint/node/public.go 81.81% 1 Missing and 1 partial ⚠️
sei-tendermint/internal/rpc/core/env.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.6    #4006      +/-   ##
================================================
- Coverage         59.04%   58.18%   -0.86%     
================================================
  Files              2228     2154      -74     
  Lines            183783   175283    -8500     
================================================
- Hits             108509   101991    -6518     
+ Misses            65507    64221    -1286     
+ Partials           9767     9071     -696     
Flag Coverage Δ
sei-chain-pr 51.33% <91.07%> (?)
sei-db 69.80% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/server/config/config.go 94.84% <ø> (+0.30%) ⬆️
sei-cosmos/server/config/toml.go 57.14% <ø> (ø)
sei-cosmos/server/start.go 25.18% <100.00%> (+0.57%) ⬆️
sei-tendermint/internal/rpc/core/evidence.go 84.61% <100.00%> (+2.79%) ⬆️
sei-tendermint/internal/rpc/core/mempool.go 44.80% <100.00%> (+1.87%) ⬆️
sei-tendermint/node/setup.go 70.30% <100.00%> (+0.27%) ⬆️
sei-tendermint/internal/rpc/core/env.go 78.28% <75.00%> (-0.08%) ⬇️
sei-tendermint/node/node.go 65.28% <77.77%> (+1.05%) ⬆️
sei-tendermint/node/public.go 72.88% <81.81%> (+8.77%) ⬆️

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih
masih marked this pull request as ready for review August 25, 2026 13:39
@cursor

cursor Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes node networking and RPC write behavior for operators using freeze-height; misconfiguration could surprise clients expecting broadcast to work while queries succeed.

Overview
When freeze-height is set on a full node, the node now runs in a stricter read-only freeze mode: query RPC stays up, but transaction and evidence broadcasts are rejected with ErrReadOnly, the mempool P2P reactor is not started, and the mempool channel is omitted from advertised node info. Mempool read paths (e.g. unconfirmed txs) remain available for queries.

validateFreezeMode is centralized at node startup so freeze height is allowed only for full nodes (validator and seed modes error). Config/CLI help in sei-cosmos is updated to describe freeze mode (including that tx/evidence submission and mempool gossip are disabled from startup). Integration tests in freeze_test.go cover mode validation and RPC/mempool behavior.

Reviewed by Cursor Bugbot for commit 3b3351e. Bugbot is set up for automated code reviews on this repo. Configure here.

@masih masih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this 🎩 (PR, not the hat)

@masih
masih enabled auto-merge (squash) August 25, 2026 13:44
@masih
masih merged commit 5b9a56b into release/v6.6 Aug 25, 2026
95 of 98 checks passed
@masih
masih deleted the backport-3990-to-release/v6.6 branch August 25, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants