Bugfix/ogc 3388 non partly reserved slots - #22
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Daverball
reviewed
Aug 13, 2026
Daverball
reviewed
Aug 13, 2026
Daverball
reviewed
Aug 13, 2026
Co-authored-by: David Salvisberg <david.salvisberg@seantis.ch>
Tschuppi81
commented
Aug 13, 2026
| blocker = scheduler.add_blocker( | ||
| (datetime(2014, 3, 7, 10, 0), datetime(2014, 3, 7, 12, 0)) | ||
| )[0] | ||
| assert blocker.id is not None |
Contributor
Author
There was a problem hiding this comment.
session.refresh is not needed, assigned id not None is verified
Daverball
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
reserved_slots_by_reservationdropping the slot on non-partly allocations