Added settings keys sorting - #533
Open
cub-uanic wants to merge 2 commits into
Open
Conversation
seanprashad
reviewed
Aug 4, 2026
seanprashad
left a comment
Owner
There was a problem hiding this comment.
Hi @cub-uanic! To sync progress across multiple hosts, you can sign in with your GitHub account:
Does this fit your use case? This was meant to replace the export/import functionality
Author
|
Hi @seanprashad, |
seanprashad
reviewed
Aug 5, 2026
seanprashad
left a comment
Owner
There was a problem hiding this comment.
Change makes sense - just one small adjustment to ensure exports won't be malformed
Comment on lines
+806
to
810
| // Serialize the JSON keys in order, so that they're stable across backups | ||
| const settings = { completed: [...completed].sort(), starred: [...starred].sort(), notes, solvedDates, reminders }; | ||
| const keys = Object.keys(settings).sort(); | ||
| const payload = Object.fromEntries(keys.map((k) => [k, settings[k as keyof typeof settings]])) + "\n"; | ||
| const blob = new Blob([JSON.stringify(payload, null, 2)], { type: "application/json" }); |
Owner
There was a problem hiding this comment.
Suggested change
| // Serialize the JSON keys in order, so that they're stable across backups | |
| const settings = { completed: [...completed].sort(), starred: [...starred].sort(), notes, solvedDates, reminders }; | |
| const keys = Object.keys(settings).sort(); | |
| const payload = Object.fromEntries(keys.map((k) => [k, settings[k as keyof typeof settings]])) + "\n"; | |
| const blob = new Blob([JSON.stringify(payload, null, 2)], { type: "application/json" }); | |
| const payload = { completed: [...completed].sort((a, b) => a - b), starred: [...starred].sort((a, b) => a - b), notes, solvedDates, reminders }; | |
| const blob = new Blob([JSON.stringify(payload, null, 2) + "\n"], { type: "application/json" }); |
Right now we're prematurely appending the \n trailing character, which causes JSON.stringify to generate "[object Object]\n" instead of the actual JSON content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using Git to store my progress in dotfiles and share them between several hosts.
Sometimes, on different hosts, I'm getting the keys in json in a different order.
This makes it difficult to understand exactly what was changed (while in reality, it could be just one line), and also makes diffs larger.
As a solution, I suggest always sort the keys of the settings object.
(the idea is the same as I proposed in philc/vimium#4764)