Made RequireJS Export Compatible to Webpack 5#10
Open
dheerajsharmaRP wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
We investigated and fixed the webpack 5 migration of the RequireJsExportPlugin. The original webpack 4 implementation exported modules by injecting code directly into each module, but during the webpack 5 upgrade this had been replaced with runtime capture using webpack_require, which caused cross-chunk dependency issues, missing jQuery/core-js modules, and failed exports. We restored the original behavior by using webpack 5's JavascriptModulesPlugin.renderModuleContent hook to inject export registration into each module, with safeguards for non-ES modules. After the change, RequireJS aliases and module exports work correctly again, and the site is functioning without console errors.