Fix up installer and third party notices#622
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
phillipmself
pushed a commit
to phillipmself/NeuralAmpModelerPluginParametric
that referenced
this pull request
Jun 19, 2026
* Use placeholder installer license * Make installer identity configurable * Add third-party notices to installers * Open third-party notices * Update ThirdPartyNotices.txt * Add copy of ThirdPartyNotices.txt on build * Formatting * Update installer scripts and README.md * Bump iPlug2: Windows bundle path and create_bundle fixes * Fix installation of third-party notices on Windows
inanmb
pushed a commit
to inanmb/NeuralAmpModelerPlugin
that referenced
this pull request
Jun 27, 2026
* Use placeholder installer license * Make installer identity configurable * Add third-party notices to installers * Open third-party notices * Update ThirdPartyNotices.txt * Add copy of ThirdPartyNotices.txt on build * Formatting * Update installer scripts and README.md * Bump iPlug2: Windows bundle path and create_bundle fixes * Fix installation of third-party notices on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ThirdPartyNotices.txt with necessary notices about third-party software. Link to open on settings page of plugin:
PR Checklist
format.bash?Unserialization.cpp.)