Add dilation for WaveNet layer array head#296
Merged
Conversation
sdatkinson
requested changes
Jun 23, 2026
sdatkinson
left a comment
sdatkinson
left a comment
Owner
There was a problem hiding this comment.
Can I get test coverage for non-1 head dilations? Otherwise all good.
Contributor
Author
|
Sorry about the incremental update spam - the tests don't build on Windows, so I couldn't run them locally... I added a test for a non-standard head dilation ("test_nested_head_with_dilation_three"), and also a check to make sure it defaults correctly (in "test_nested_head_with_kernel_size_three"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a config variable ("head_dilation") to specify the dilation for the WaveNet layer array head.
It also adds a corresponding check for the A2 fast path.
Resolves #293