feat: implement auto-spacing after punctuation and double-tap space period (#669) - #670
Open
prince-0408 wants to merge 4 commits into
Open
Conversation
…eriod (scribe-org#669) - Add auto-space after punctuation (. , ! ?) setting and key handling - Refine double-tap space for period conversion and auto-capitalization - Default auto-spacing and double-tap period preferences to enabled - Add unit tests for SpaceKeyProcessor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements two standard soft-keyboard usability features as requested in #669 by adding automatic punctuation spacing and refining double-tap space for period behavior to align with modern keyboard standards (such as Gboard and SwiftKey).
Key Changes
Double-Tap Space for Period (
.):SpaceKeyProcessor.ktso that pressing the spacebar twice after a word converts the trailing space to a period and space (.).SHIFT_ON_ONE_CHAR) on period conversion to capitalize the first letter of the next sentence.Auto-Spacing After Punctuation:
KeyHandler.ktto intercept punctuation keys (.,,,!,?) and automatically append a trailing space when typed after a word....or?!) or backspace is typed.Settings & Preferences Integration:
AUTO_SPACE_AFTER_PUNCTUATIONconstant, getter, and setter inPreferencesHelper.kt.true).LanguageSettingsScreen.kt.en-US/string.xml.Unit Tests & Linter Cleanliness:
SpaceKeyProcessorTest.ktfor spacebar event processing and period commits../gradlew formatKotlinto ensure clean compliance withktlintanddetekt.Visual Demonstration
Related Issue
Closes #669