refactor: deduplicate isTablet method across language subclasses (#426) - #667
Open
prince-0408 wants to merge 2 commits into
Open
refactor: deduplicate isTablet method across language subclasses (#426)#667prince-0408 wants to merge 2 commits into
prince-0408 wants to merge 2 commits into
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is Part 2 of 6 in modularizing
GeneralKeyboardIMEto resolve #426.It removes duplicate
isTablet()implementations andSMALLEST_SCREEN_WIDTH_TABLET = 600constants across all 8 language keyboard subclasses and standardizes tablet detection inKeyboardUIManager.kt.Summary of Changes Table:
GeneralKeyboardIME.ktprotected open fun isTablet()&SMALLEST_SCREEN_WIDTH_TABLET = 600KeyboardUIManager.ktisTabletto useGeneralKeyboardIME.SMALLEST_SCREEN_WIDTH_TABLETEnglishKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETFrenchKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETGermanKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETItalianKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETPortugueseKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETRussianKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETSpanishKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETSwedishKeyboardIME.ktisTablet()&SMALLEST_SCREEN_WIDTH_TABLETKey Benefits:
Related Issue
Refactors part of #426
Type of Change