[ESSREDUCE] refactor: WIP - #689
Closed
jokasimr wants to merge 1 commit into
Closed
Conversation
SimonHeybrock
left a comment
Member
There was a problem hiding this comment.
With a new look, I think a remember our discussion from before summer (on the original PR), as well as some new comments:
- Concerns about having
modelinParameterSpec. My idea was thatWorkflowSpecshould be independent of workflow implementation. Havingmodelkind of prescribes ascilineimplementation. use_workflow_defaultis similar (linked to what we have in our sciline-based workflows). I think our conclusion was that we should never use workflow defaults.- I think
titleanddescriptionshould be mandatory. - Is
ParameterSpecnecessary, or would it be cleaner to just usepydantic? We may alternatively consider using aProtocolthat could be fulfilled by Pydantic models. WorkflowSpec:typical_outputsand other rather bespoke fields should likely be kept out of a generic spec, at least in v0. This feature was what we used in the original UI generation code, but should maybe be kept in a subclass for now (not part of this PR).- Is
WorkflowRegistrynecessary? - Why does
WorkflowSpechold a workflow factory? The intent ofWorkflowSpecis to be generic metadata for a workflow, this seems to much tied to what is implemented concretely (based on old implementation)?
I think it is easier to have a fresh suggestion instead of editing all this into this one. I will open a PR for discussion.
Member
|
As announced above, I have opened #690 as a fresh take — pure-interface spec (no factory, no sciline keys), one pydantic params model per workflow, plus an ADR with the rationale. Thanks for the groundwork here; much of the analysis carried over. I propose we close this PR and continue the discussion on #690. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from #654