Support enclosing_symbol, multiline occurrences, and synthetic_definition in snapshots#445
Open
jupblb wants to merge 3 commits into
Open
Support enclosing_symbol, multiline occurrences, and synthetic_definition in snapshots#445jupblb wants to merge 3 commits into
enclosing_symbol, multiline occurrences, and synthetic_definition in snapshots#445jupblb wants to merge 3 commits into
Conversation
…definition Render enclosing_symbol in definition info blocks, multiline occurrences on their start line with a lineDelta:endChar suffix, and synthetic_definition occurrences (derived from is_definition relationships) using '_' markers. Also render the is_definition relationship flag and clamp empty ranges to a single marker.
Recognize the '_' marker and synthetic_definition kind (derived from is_definition relationships), parse the multiline <lineDelta>:<endChar> suffix, and ignore range-less snapshot metadata lines so snapshot blocks can be pasted into test files. Fix an index-out-of-range panic when the expected symbol has more parts than the actual. Share marker/synthetic helpers with the snapshot formatter.
jupblb
changed the title
enclosing_symbol, multiline occurrences, and synthetic_definition in snapshots
trly
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
enclosing_symbol, multiline occurrences, andsynthetic_definitioninscip snapshot, and forsynthetic_definitionand multiline occurrences inscip test.