Fix the CURR-column download dump in ZCMRUPDATE_ADDON_TABLE - #10
Merged
Conversation
do_download's convert_to_external passed max_number_of_digits = 23 to BAPI_CURRENCY_CONV_TO_EXTERNAL, but that parameter exists only on the _TO_INTERNAL twin (verified against the live FM interface on S4D, 2026-08-07). An unknown parameter raises CALL_FUNCTION_PARM_UNKNOWN, a runtime error the surrounding CATCH cx_root cannot intercept, so downloading any table with a CURR column short-dumped. The compiler syntax check does not catch this (verified with a minimal repro); only an FM-signature check does. Minimal fix: drop the parameter -- the _TO_EXTERNAL direction needs no digit cap. The upload path's _TO_INTERNAL call keeps it (mandatory there). No selection-screen fields renamed: sap_update_addon_prog.vbs drives RB_UP/RB_DOWN by GUI field id. Deployed systems carry the same bug: the program on S4D (pkg ZCMDEVAI) is byte-identical to this reference copy, so each system needs a redeploy via /sap-dev-init (or /sap-se38 update of ZCMRUPDATE_ADDON_TABLE) to pick the fix up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
do_download'sconvert_to_externalpassedmax_number_of_digits = 23toBAPI_CURRENCY_CONV_TO_EXTERNAL, but that parameter exists only on the_TO_INTERNALtwin (verified against the live FM interface on S4D, 2026-08-07). An unknown parameter raisesCALL_FUNCTION_PARM_UNKNOWN— a runtime error the surroundingCATCH cx_rootcannot intercept — so downloading any table with a CURR column short-dumped.Fix
_TO_EXTERNALcall (that direction needs no digit cap); re-align the two surviving parameters; add a two-line comment stating the constraint so the parameter isn't copied back from the upload path for symmetry._TO_INTERNALcall keepsmax_number_of_digits— it is legitimate and mandatory there.sap_update_addon_prog.vbsdrivesRB_UP/RB_DOWNby GUI field id).[Unreleased] → Fixed.Notes
/sap-check-abapfmdimension) does./sap-dev-initdeploys is byte-identical to this reference copy, so deployed systems (e.g. S4D, pkgZCMDEVAI) carry the dump untilZCMRUPDATE_ADDON_TABLEis redeployed via/sap-dev-initor a/sap-se38update.Verification
node scripts/check-consistency.mjs→OK: 4 plugins, 123 skills, all manifests aligned at version 0.8.1, Tier 3 attach contract clean, screen-baseline coverage 136/136🤖 Generated with Claude Code