Skip to content

Fix for Rack 3 [Sequencescape] - #20

Open
StephenHulme wants to merge 23 commits into
developfrom
sh51/rack-3-fix
Open

Fix for Rack 3 [Sequencescape]#20
StephenHulme wants to merge 23 commits into
developfrom
sh51/rack-3-fix

Conversation

@StephenHulme

@StephenHulme StephenHulme commented Aug 11, 2026

Copy link
Copy Markdown
Member

Contributes towards closing #7

Changes:

  • Fix for Rack 3 compatibility in Sequencescape
  • Add Ruby 3.4 and Rails 8.0 to test matrix
  • Update checkout action
  • Update dependencies for Rails 8.0
  • Add minitest reporter
  • Fix failing test setup
  • Migrate error and deprecation handling to modern rails

Comment thread lib/jsonapi/error.rb
@links = options[:links]

@status = Rack::Utils.status_code(options[:status]).to_s
@status = status_code(options[:status]).to_s

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rack 3 warning fix

@BenTopping BenTopping left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Comment thread lib/jsonapi/error.rb
Comment thread lib/jsonapi/error.rb
Comment thread lib/jsonapi/request_parser.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants