Defer master file list fetch in source_list until a salt:// URL is encountered#69823
Open
mangodxd wants to merge 2 commits into
Open
Defer master file list fetch in source_list until a salt:// URL is encountered#69823mangodxd wants to merge 2 commits into
mangodxd wants to merge 2 commits into
Conversation
twangboy
requested changes
Jul 17, 2026
twangboy
left a comment
twangboy
left a comment
Contributor
There was a problem hiding this comment.
Looks like you have commits from another PR in here. The changelog and tests aren't related to your file.managed fixes. Please remove those and add a changelog and tests for these changes.
Instead of eagerly calling cp.list_master for every source list, defer the fetch until a salt:// URL is actually encountered. Fixes saltstack#69804.
mangodxd
force-pushed
the
fix/defer-list-master-fetch
branch
from
July 18, 2026 16:49
f6a385c to
218dfaf
Compare
Author
|
Fixed. I've cleaned up the branch — removed the unrelated ZMQ commits and added:
The branch now only contains the ile.py change plus changelog and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every state using file.managed with a list source paid the cost of a full fileserver scan upfront, even when the first source was HTTP or local. Defer the cp.list_master / cp.list_master_dirs calls until a salt:// URL is actually hit.